rdblue commented on a change in pull request #2001:
URL: https://github.com/apache/iceberg/pull/2001#discussion_r551625141
##########
File path: parquet/src/main/java/org/apache/iceberg/parquet/ParquetWriter.java
##########
@@ -124,10 +125,20 @@ public Metrics metrics() {
return ParquetUtil.footerMetrics(writer.getFooter(), model.metrics(),
metricsConfig);
}
+ /**
+ * Returns the number of bytes written by this writer.
+ * NOTE: call {@link ParquetWriter#close()})} prior this method to get the
exact number of bytes.
Review comment:
This is going to be wrapped into a single paragraph. Also, it is okay to
describe the behavior without `NOTE`.
How about this?
```java
/**
* Returns the approximate length of the output file produced by this
writer.
* <p>
* Prior to calling {@link ParquetWriter#close}, the result is
approximate. After calling close, the length is exact.
*/
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
