pvary commented on a change in pull request #2053:
URL: https://github.com/apache/iceberg/pull/2053#discussion_r553942111
##########
File path:
mr/src/main/java/org/apache/iceberg/mr/mapreduce/IcebergInputFormat.java
##########
@@ -373,15 +375,18 @@ public void close() throws IOException {
}
}
- private static Schema readSchema(Configuration conf, Schema tableSchema) {
+ private static Schema readSchema(Configuration conf, Schema tableSchema,
boolean caseSensitive) {
Schema readSchema = InputFormatConfig.readSchema(conf);
if (readSchema != null) {
return readSchema;
}
String[] selectedColumns = InputFormatConfig.selectedColumns(conf);
- return selectedColumns != null ? tableSchema.select(selectedColumns) :
tableSchema;
+ if (selectedColumns == null) {
+ return tableSchema;
+ }
+ return caseSensitive ? tableSchema.select(selectedColumns) :
tableSchema.caseInsensitiveSelect(selectedColumns);
Review comment:
nit: Extra line
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
