RussellSpitzer commented on code in PR #16910:
URL: https://github.com/apache/iceberg/pull/16910#discussion_r3814286278
##########
core/src/main/java/org/apache/iceberg/RewriteTablePathUtil.java:
##########
@@ -283,6 +301,19 @@ public static RewriteResult<ManifestFile>
rewriteManifestList(
mf.path(),
sourcePrefix));
+ long unmeasured =
Review Comment:
On this point, maybe we should just change the API entirely so that we only
take this map of manifest to length. We only want to be able to rewrite entries
with a length, so we may as well just drop the Set and just have Map<Manifest,
Length> be the only thing we allow passing through. Then there is no ability to
rewrite a manifest unless you also pass through a length.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
