varun-lakhyani commented on code in PR #16910:
URL: https://github.com/apache/iceberg/pull/16910#discussion_r3814464259
##########
core/src/main/java/org/apache/iceberg/RewriteTablePathUtil.java:
##########
@@ -283,6 +301,19 @@ public static RewriteResult<ManifestFile>
rewriteManifestList(
mf.path(),
sourcePrefix));
+ long unmeasured =
Review Comment:
I think there is an issue in dropping Set.
We are iterating over `List<ManifestFile> manifestFiles =
manifestFilesInSnapshot(io, snapshot);` which is source of manifest that might
not have updated length in the map and only thing helping us fail hard using
**`precondition`** is Set manifestsToRewrite which contains all that should
have new length and map which contains all that has recorded new length.
We are iterating through all as there could be manifests which not need
rewrite but we have to include them anyway
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
