varun-lakhyani commented on code in PR #16910:
URL: https://github.com/apache/iceberg/pull/16910#discussion_r3814535622
##########
core/src/main/java/org/apache/iceberg/RewriteTablePathUtil.java:
##########
@@ -283,6 +301,19 @@ public static RewriteResult<ManifestFile>
rewriteManifestList(
mf.path(),
sourcePrefix));
+ long unmeasured =
Review Comment:
If we want real fail hard - fail at all incremental rewrites too then we can
drop set and put the precondition on manifestinsnapshot against the map.
This way we are 100% sure there is no way we are getting wrong length but we
will loose incremental rewrite completely as it fails everytime.
Not sure what's more important going forward
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
