pvary commented on pull request #2053: URL: https://github.com/apache/iceberg/pull/2053#issuecomment-756755423
> > > @pvary, i just pushed a commit, could you please take a look? > > > > > > Just answered 😄 > > Since the queries in the new test cases do not use the execution engine itself (they are using only local tasks), we do need them in both classes. It is enough to have them in the `TestHiveIcebergStorageHandlerLocalScan.java` > > Thanks, i've removed the test code in TestHiveIcebergStorageHandlerWithEngine. Thanks @dixingxing0 for the patch! Few last nits and then I think it is good. +1 non-binding @rdblue: Could you please review? Thanks, Peter ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
