rdblue commented on a change in pull request #2053:
URL: https://github.com/apache/iceberg/pull/2053#discussion_r555277051
##########
File path:
mr/src/main/java/org/apache/iceberg/mr/hive/serde/objectinspector/IcebergObjectInspector.java
##########
@@ -65,17 +65,26 @@
.invoke();
public static ObjectInspector create(@Nullable Schema schema) {
+ return create(schema, true);
+ }
+
+ public static ObjectInspector create(@Nullable Schema schema, boolean
caseSensitive) {
Review comment:
Why accept a case sensitivity setting for something that is only used by
Hive? I thought that the purpose of this PR was to allow case sensitive
behavior for the InputFormat, but not Hive because Hive's behavior is case
insensitive.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
