blackmwk commented on PR #3058: URL: https://github.com/apache/iceberg-rust/pull/3058#issuecomment-5392416924
> Thanks for the feedback @blackmwk. Did you mean that we should derive `_row_id` in a reader/stream layer over the parquet stream, instead of in `RecordBatchTransformer`? > We could have a small reader step computing first_row_id + pos (coalescing the physical _row_id leaf), with the transformer just passing `_row_id` through like `_pos`. Is that what you meant? Yes, that's what I think. It's impossible to compute `_row_id` in iceberg layer, give the filter pushed to parquet arrow reader and row group pruning. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
