anoopj commented on code in PR #3058:
URL: https://github.com/apache/iceberg-rust/pull/3058#discussion_r3845684735
##########
crates/iceberg/src/arrow/record_batch_transformer.rs:
##########
@@ -263,6 +276,11 @@ pub(crate) enum ColumnConstant {
/// per-row value is null (e.g. `_last_updated_sequence_number` on a file
that
/// carries the column, falling back to the data sequence number).
CoalesceLastUpdatedSeq(Datum),
+ /// The `_row_id` metadata column. `Some(first_row_id)` synthesizes it
(the per-row
+ /// value where the file physically carries `_row_id`, else `first_row_id`
plus the
+ /// row's position); `None` produces an all-null column (a file with a null
+ /// `first_row_id`).
+ RowId(Option<i64>),
Review Comment:
Resolved by removing it entirely rather than renaming. Per blackmwk's
feedback, _row_id synthesis moved out of RecordBatchTransformer into a
reader-level stream step , so there's no longer a per-row constant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
