anoopj commented on code in PR #3058:
URL: https://github.com/apache/iceberg-rust/pull/3058#discussion_r3845686952
##########
crates/iceberg/src/arrow/reader/pipeline.rs:
##########
@@ -289,6 +298,28 @@ impl FileScanTaskReader {
let coalesce_last_updated_seq_leaf = phys_last_updated_seq_leaf
.filter(|_| task.first_row_id.is_some() &&
task.data_sequence_number.is_some());
+ let phys_row_id_leaf = if project_row_id {
+ find_leaf_by_field_id(
+ record_batch_stream_builder.parquet_schema(),
+ RESERVED_FIELD_ID_ROW_ID,
+ )
+ } else {
+ None
+ };
+
+ // Present by name but without the embedded id: unthreadable, rejected
below.
+ let row_id_present_by_name_only = project_row_id
Review Comment:
Fixed. The guard is now gated on !use_position_fallback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
