vishnuprakaz commented on PR #17630:
URL: https://github.com/apache/iceberg/pull/17630#issuecomment-5394390535

   Thanks @mxm Sorry for the delay. Addressed the comments.
   
    The re inserts needed a row count check as well: with `("id","data")` as 
equality fields a re-insert is an identical row, so the set comparison can't 
tell it apart from a resurrected one. With the count it fails 2 vs 3 without 
the fix.
   
   I left `ensureIndexCurrent` before the no-op return so the index still 
bootstraps on empty triggers.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to