mxm commented on code in PR #17630:
URL: https://github.com/apache/iceberg/pull/17630#discussion_r3849491899
##########
flink/v2.1/flink/src/test/java/org/apache/iceberg/flink/maintenance/api/TestConvertEqualityDeletes.java:
##########
@@ -1413,7 +1406,6 @@ void testDeleteResolvedBeforeFailureIsRetained() throws
Exception {
// The retried cycle converted both eq deletes, so only the re-inserts
remain visible.
assertNoEqualityDeletesOnMain(table, 0);
assertRecords(table, ImmutableList.of(createRecord(1, "a"),
createRecord(2, "b")));
- assertThat(visibleRowCount(table)).isEqualTo(2);
Review Comment:
Can we change the `assertRecords` method to avoid creating Sets to compare
the table data with the expected data? We should use lists instead to detect
duplicates.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
