ebyhr commented on code in PR #17871:
URL: https://github.com/apache/iceberg/pull/17871#discussion_r3888416320
##########
bigquery/src/main/java/org/apache/iceberg/gcp/bigquery/BigQueryMetastoreCatalog.java:
##########
@@ -249,16 +249,8 @@ public boolean setProperties(Namespace namespace,
Map<String, String> properties
@Override
public boolean removeProperties(Namespace namespace, Set<String> properties)
{
- if (!namespaceExists(namespace)) {
- throw new NoSuchNamespaceException("Namespace does not exist: %s",
namespace);
- }
-
Preconditions.checkNotNull(properties, "Invalid properties to remove:
null");
- if (properties.isEmpty()) {
- return false;
- }
Review Comment:
What's the motivation to remove this condition? I think we don't need to
call `BigQueryMetastoreClient#removeParameters` when `properties` is empty.
##########
bigquery/src/main/java/org/apache/iceberg/gcp/bigquery/BigQueryMetastoreCatalog.java:
##########
@@ -249,16 +249,8 @@ public boolean setProperties(Namespace namespace,
Map<String, String> properties
@Override
public boolean removeProperties(Namespace namespace, Set<String> properties)
{
- if (!namespaceExists(namespace)) {
- throw new NoSuchNamespaceException("Namespace does not exist: %s",
namespace);
- }
-
Preconditions.checkNotNull(properties, "Invalid properties to remove:
null");
- if (properties.isEmpty()) {
- return false;
- }
Review Comment:
What's the motivation to remove this condition? I don't think we need to
call `BigQueryMetastoreClient#removeParameters` when `properties` is empty.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
