charliec05 commented on code in PR #17871:
URL: https://github.com/apache/iceberg/pull/17871#discussion_r3901219532
##########
bigquery/src/main/java/org/apache/iceberg/gcp/bigquery/BigQueryMetastoreCatalog.java:
##########
@@ -249,16 +249,8 @@ public boolean setProperties(Namespace namespace,
Map<String, String> properties
@Override
public boolean removeProperties(Namespace namespace, Set<String> properties)
{
- if (!namespaceExists(namespace)) {
- throw new NoSuchNamespaceException("Namespace does not exist: %s",
namespace);
- }
-
Preconditions.checkNotNull(properties, "Invalid properties to remove:
null");
Review Comment:
Addressed. The extra blank line after validation is gone; the restored
empty-set guard now follows the precondition directly.
##########
bigquery/src/main/java/org/apache/iceberg/gcp/bigquery/BigQueryMetastoreCatalog.java:
##########
@@ -249,16 +249,8 @@ public boolean setProperties(Namespace namespace,
Map<String, String> properties
@Override
public boolean removeProperties(Namespace namespace, Set<String> properties)
{
- if (!namespaceExists(namespace)) {
- throw new NoSuchNamespaceException("Namespace does not exist: %s",
namespace);
- }
-
Preconditions.checkNotNull(properties, "Invalid properties to remove:
null");
- if (properties.isEmpty()) {
- return false;
- }
Review Comment:
Agreed. I restored the empty-set short circuit and added a regression test
that verifies the BigQuery client has no interactions in this case. The full
`:iceberg-bigquery:test` suite passes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
