anoopj commented on code in PR #3117:
URL: https://github.com/apache/iceberg-rust/pull/3117#discussion_r3895482580
##########
crates/iceberg/src/arrow/reader/pipeline.rs:
##########
@@ -230,7 +230,13 @@ impl FileScanTaskReader {
// column, so nothing is synthesized and the column is not needed.
let need_row_number = project_pos || (project_row_id &&
task.first_row_id.is_some());
- let arrow_metadata = if need_row_number {
+ let field_ids = task.project_field_ids();
+ let metadata_only_projection =
+ !field_ids.is_empty() && field_ids.iter().all(|&id|
is_metadata_field(id));
Review Comment:
Thanks for the callout. I think that makes a lot of sense. Incorporating.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
