anoopj commented on code in PR #3117:
URL: https://github.com/apache/iceberg-rust/pull/3117#discussion_r3895546639
##########
crates/iceberg/src/arrow/reader/pipeline.rs:
##########
@@ -3246,8 +3400,8 @@ mod tests {
// Seq-only projection with a null first_row_id: the column is nulled
and the
// physical leaf is NOT read (the gated
`coalesce_last_updated_seq_leaf` is None).
- // The downgrade must therefore not fire -- keying off the raw
`project_*` flag
- // instead would drop the only readable column and lose the row count.
+ // This is a metadata-only projection, so RowNumber is installed as
the row-count
+ // source and the data columns are pruned; the row count must still be
3.
Review Comment:
Done. Reworked it as `test_file_only_reads_no_data_columns`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
