anoopj commented on code in PR #3117:
URL: https://github.com/apache/iceberg-rust/pull/3117#discussion_r3895540482
##########
crates/iceberg/src/arrow/reader/pipeline.rs:
##########
@@ -3300,8 +3454,8 @@ mod tests {
metadata_projection_task(file_path.clone(), schema,
vec![RESERVED_FIELD_ID_FILE]);
let (batches, _) = scan_task(task).await;
- // A pure-constant projection has no independent row source, so the
row count must
- // still come from the file (the `empty -> all()` path is preserved
for this case).
+ // A metadata-only constant projection is pruned to zero data columns;
RowNumber
+ // supplies the row count and the `_file` constant is sized from it (3
rows).
let total_rows: usize = batches.iter().map(|b| b.num_rows()).sum();
assert_eq!(total_rows, 3);
Review Comment:
Done. Renamed to `test_seq_only_null_first_row_id_reads_no_data_columns`
and mirrored the validations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
