danielcweeks commented on code in PR #17457:
URL: https://github.com/apache/iceberg/pull/17457#discussion_r3916984550
##########
aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIO.java:
##########
@@ -88,8 +89,10 @@
* FileIO implementation backed by S3.
*
* <p>Locations used must follow the conventions for S3 URIs (e.g.
s3://bucket/path...). URIs with
- * schemes s3a, s3n, https are also treated as s3 file paths. Using this
FileIO with other schemes
- * will result in {@link org.apache.iceberg.exceptions.ValidationException}.
+ * schemes s3a, s3n are also treated as s3 file paths. HTTP(S) URL locations
(e.g. a catalog-vended
+ * pre-signed URL) are read directly over HTTP(S) instead of through the
native, credentialed S3
+ * client; see {@link #newInputFile(String)}. Using this FileIO with other
schemes will result in
+ * {@link org.apache.iceberg.exceptions.ValidationException}.
Review Comment:
I don't think this clarification is necessary. We're exposing
implementation which isn't necessary. The existing documentation states https
is supported, so we don't need this addition context.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
