danielcweeks commented on code in PR #17457: URL: https://github.com/apache/iceberg/pull/17457#discussion_r3918563717
########## core/src/main/java/org/apache/iceberg/io/http/HttpHeaderUtil.java: ########## @@ -0,0 +1,88 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.io.http; + +import org.apache.hc.core5.http.ClassicHttpResponse; +import org.apache.hc.core5.http.Header; + +/** + * Reads a file's content length from the HTTP response to a {@code GET Range: bytes=0-0} probe. + * + * <p>A length that cannot be determined is reported as {@link #UNKNOWN_LENGTH}. + */ +class HttpHeaderUtil { Review Comment: This util class doesn't strike me as necessary. This is logic that should be part of the HTTPInputFile implementation. I don't think we need a separate class for this functionality? Generally, utility classes are created when there are multiple independent use cases, but that doesn't seem to be the case here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
