danielcweeks commented on code in PR #17457: URL: https://github.com/apache/iceberg/pull/17457#discussion_r3916996046
########## aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIO.java: ########## @@ -108,6 +114,8 @@ public class S3FileIO private SerializableMap<String, String> properties = null; private MetricsContext metrics = MetricsContext.nullMetrics(); private final AtomicBoolean isResourceClosed = new AtomicBoolean(false); + private transient volatile HttpUrlClient httpUrlClient; Review Comment: The http client shouldn't be at the S3FileIO, but rather managed by the HTTPInput/Output Class structure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
