anoopj commented on code in PR #3179:
URL: https://github.com/apache/iceberg-rust/pull/3179#discussion_r3970464058
##########
crates/storage/opendal/src/lib.rs:
##########
@@ -233,6 +235,9 @@ pub enum OpenDalStorage {
S3 {
/// S3 configuration.
config: Arc<S3Config>,
+ /// Bytes carried by one multipart upload request.
+ #[serde(default = "default_multipart_part_size")]
+ multipart_part_size: usize,
Review Comment:
This field is serialized and is round-tripped. A `usize`-typed serialized
value ties the wire format to host word size. This might cause issues if we
have heterogeneous setup (granted, they are rare). Consider storing `u64` and
converting as `usize` somewhere in the edge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
