YuangGao commented on code in PR #3179:
URL: https://github.com/apache/iceberg-rust/pull/3179#discussion_r4044271950
##########
crates/storage/opendal/src/lib.rs:
##########
@@ -233,6 +235,9 @@ pub enum OpenDalStorage {
S3 {
/// S3 configuration.
config: Arc<S3Config>,
+ /// Bytes carried by one multipart upload request.
+ #[serde(default = "default_multipart_part_size")]
+ multipart_part_size: u64,
Review Comment:
i think `pub(crate) `isn't possible here — enum variants and their fields
always share the enum's visibility (E0449). Hiding it would mean a wrapper
struct or `#[non_exhaustive]`, but those break source compatibility too, so
there's nothing to gain. I've left the field public and marked the commit fix!
so the break shows up in the release notes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
