YuangGao commented on code in PR #3179:
URL: https://github.com/apache/iceberg-rust/pull/3179#discussion_r4033421240
##########
crates/storage/opendal/src/lib.rs:
##########
@@ -175,6 +176,7 @@ impl StorageFactory for OpenDalStorageFactory {
customized_credential_load,
} => Ok(Arc::new(OpenDalStorage::S3 {
config: s3_config_parse(config.props().clone())?.into(),
+ multipart_part_size:
s3_multipart_part_size_parse(config.props())?,
Review Comment:
S3Config here is opendal's own `#[non_exhaustive] `struct, so we can't add
fields to it — and opendal doesn't model chunk size as service config anyway,
it's a per-write option on `WriteOptions`. Since S3Config gets consumed by
`into_builder()` when the `Operator` is built, the value has to be carried
separately until the actual write call
let me know if you had something else in mind
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
