lcspinter commented on a change in pull request #2086:
URL: https://github.com/apache/iceberg/pull/2086#discussion_r557218244
##########
File path: mr/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergSerDe.java
##########
@@ -137,15 +137,21 @@ private static Schema hiveSchemaOrThrow(Properties
serDeProperties, Exception pr
// Read the configuration parameters
String columnNames =
serDeProperties.getProperty(serdeConstants.LIST_COLUMNS);
String columnTypes =
serDeProperties.getProperty(serdeConstants.LIST_COLUMN_TYPES);
+ // No constant for column comments and column comments delimiter.
Review comment:
What I meant here, that there is no constant definition among the
serdeConstants, therefore I had to hardcode the column comment
("columns.comments") and column delimiter (Character.MIN_VALUE) property names.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
