pvary commented on a change in pull request #2086:
URL: https://github.com/apache/iceberg/pull/2086#discussion_r558268127
##########
File path:
mr/src/test/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandlerTestUtils.java
##########
@@ -36,9 +36,9 @@
new FileFormat[] {FileFormat.AVRO, FileFormat.ORC, FileFormat.PARQUET};
static final Schema CUSTOMER_SCHEMA = new Schema(
- optional(1, "customer_id", Types.LongType.get()),
- optional(2, "first_name", Types.StringType.get()),
- optional(3, "last_name", Types.StringType.get())
+ optional(1, "customer_id", Types.LongType.get(), "This is an ID"),
+ optional(2, "first_name", Types.StringType.get(), "This is first
name"),
+ optional(3, "last_name", Types.StringType.get(), "This is last name")
Review comment:
do we have to have a comment for all of columns?
shall we test at least one without a comment?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
