rdblue commented on a change in pull request #2086:
URL: https://github.com/apache/iceberg/pull/2086#discussion_r562306320
##########
File path:
mr/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergStorageHandlerNoScan.java
##########
@@ -504,21 +506,60 @@ public void
testCreateTableWithNotSupportedTypesWithAutoConversion() {
TableIdentifier identifier = TableIdentifier.of("default",
"not_supported_types");
// Can not create INTERVAL types from normal create table, so leave them
out from this test
Map<String, Type> notSupportedTypes = ImmutableMap.of(
- "TINYINT", Types.IntegerType.get(),
- "SMALLINT", Types.IntegerType.get(),
- "VARCHAR(1)", Types.StringType.get(),
- "CHAR(1)", Types.StringType.get());
+ "TINYINT", Types.IntegerType.get(),
+ "SMALLINT", Types.IntegerType.get(),
+ "VARCHAR(1)", Types.StringType.get(),
+ "CHAR(1)", Types.StringType.get());
Review comment:
Can you revert these whitespace-only changes?
##########
File path:
hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveSchemaUtil.java
##########
@@ -181,16 +182,16 @@ public void testComplexTypeAndTypeInfoConvert() {
protected Schema getSchemaWithSupportedTypes() {
return new Schema(
- optional(0, "c_float", Types.FloatType.get()),
- optional(1, "c_double", Types.DoubleType.get()),
- optional(2, "c_boolean", Types.BooleanType.get()),
- optional(3, "c_int", Types.IntegerType.get()),
- optional(4, "c_long", Types.LongType.get()),
- optional(5, "c_binary", Types.BinaryType.get()),
- optional(6, "c_string", Types.StringType.get()),
- optional(7, "c_timestamp", Types.TimestampType.withoutZone()),
- optional(8, "c_date", Types.DateType.get()),
- optional(9, "c_decimal", Types.DecimalType.of(38, 10)));
+ optional(0, "c_float", Types.FloatType.get(), ""),
+ optional(1, "c_double", Types.DoubleType.get(), ""),
+ optional(2, "c_boolean", Types.BooleanType.get(), ""),
+ optional(3, "c_int", Types.IntegerType.get(), ""),
+ optional(4, "c_long", Types.LongType.get(), ""),
+ optional(5, "c_binary", Types.BinaryType.get(), ""),
+ optional(6, "c_string", Types.StringType.get(), ""),
+ optional(7, "c_timestamp", Types.TimestampType.withoutZone(), ""),
+ optional(8, "c_date", Types.DateType.get(), ""),
+ optional(9, "c_decimal", Types.DecimalType.of(38, 10), ""));
Review comment:
Just to make sure: this should not use empty string if there is no
comment. If there is no comment, then it should use null. It's a little
misleading to see empty string like this in tests. Could you remove half of
them and add non-empty doc strings to the other half?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
