danielcweeks commented on code in PR #17332:
URL: https://github.com/apache/iceberg/pull/17332#discussion_r3992139348
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -1429,6 +1429,67 @@ paths:
5XX:
$ref: '#/components/responses/ServerErrorResponse'
+ /v1/{prefix}/namespaces/{namespace}/tables/{table}/presign:
Review Comment:
> I am assuming in the current execution we need to start sending pre-sign
is the client is expecting pre-signed urls only though i wonder if we introduce
this header, what happens to existing clients using this endpoint which will
not send this header, should we add no header means remote-sign ? because the
fact this endpoint is called it means someone wants to access only ... unlike
loadTable where it would be just metadata (if this
X-Iceberg-Access-Delegation)...
I'm not sure I'm fully following this comment, but I think we would expect
the default to be remote signing for backward compatibility. We also add a
field in the response to identify the mechanism used to sign, but the presence
of an specific values in the header or query params of the URI would clearly
indicate the type of signature (it's trivially self discoverable).
>regarding having mixed mode ...
We haven't had a community discussion on access delegation for File, so I
would defer making decisions here about how we handle that scenario. Though
this might just be something we add to the remote signing config. Again, this
should be the catalog who decides, not the client. The client might offer up
what it supports or prefers (e.g. the access delegation header), but the
catalog determines how and whether it provides access (not the client).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
