singhpk234 commented on code in PR #17332:
URL: https://github.com/apache/iceberg/pull/17332#discussion_r3992567118


##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -1429,6 +1429,67 @@ paths:
         5XX:
           $ref: '#/components/responses/ServerErrorResponse'
 
+  /v1/{prefix}/namespaces/{namespace}/tables/{table}/presign:
+    parameters:
+      - $ref: '#/components/parameters/prefix'
+      - $ref: '#/components/parameters/namespace'
+      - $ref: '#/components/parameters/table'
+
+    post:
+      tags:
+        - Catalog API
+      summary: Refreshes pre-signed URLs for files from a completed scan 
planning result
+      description: >
+        Refreshes pre-signed URLs for a set of files that were returned as 
part of a
+        previous server-side scan planning result, identified by its plan-id.
+
+
+        This endpoint is intended for lightweight, proactive renewal of 
expiring URLs
+        (for example by a background caching daemon) and does not re-evaluate 
the
+        table's manifests or any pushed-down filters. It is only available 
when the
+        pre-signed-urls access delegation mechanism has been negotiated with 
the
+        planTableScan endpoint via the X-Iceberg-Access-Delegation header.

Review Comment:
   > Scan/plan doesn't require a new endpoint though, since the pre-signed urls 
are being sent back directly
   
   This is for refresh scenario, though, for example spark's drive planned the 
splits and got the presigned urls back and distributed the files to the 
executors before the executors actually starts processing the files the url 
expires we would want to reach out to server to get this refreshed !
   Also sending the plan id would help in audit etc as well ... optional for 
sure !
   
   regarding endpoint, will update this to /sign endpoint as we discussed in 
the community sync !
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to