singhpk234 commented on code in PR #17332:
URL: https://github.com/apache/iceberg/pull/17332#discussion_r3992544510


##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -1429,6 +1429,67 @@ paths:
         5XX:
           $ref: '#/components/responses/ServerErrorResponse'
 
+  /v1/{prefix}/namespaces/{namespace}/tables/{table}/presign:

Review Comment:
   what i meant is unlike loadTable where a client can just call it to get 
table metadata ... not sending an access-delegation mode is fine .... but if 
one is calling sign endpoint and not requesting anything in the header might be 
odd, so from protocol POV and backward compatibility we might want to say it 
means client is requesting remote signing explicitly in spec.
   
   > but the presence of an specific values in the header or query params of 
the URI would clearly indicate the type of 
   
   Presently the response obj has a separate header field in the remote sign 
because of the nature of remote sign so we can treat this as the way for client 
to know it got remote sign back 
   
   
https://github.com/apache/iceberg/blob/53d0e73f9d03e03805744bb9a13531ea12577efb/open-api/rest-catalog-open-api.yaml#L5854
   
   > so I would defer making decisions here about how we handle that scenario
   
   Fair, hence was saying future discussions ! though agree with the principle 
here catalog should orchestrate how it wants to give access to underlying 
storage ... this data / record level make me really curious !
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to