alexanderbianchi commented on code in PR #3000: URL: https://github.com/apache/iceberg-rust/pull/3000#discussion_r4000793180
########## crates/integrations/datafusion/src/options.rs: ########## @@ -0,0 +1,107 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +use std::collections::HashMap; + +use datafusion::catalog::Session as DFSession; +use iceberg::SessionContext; +use iceberg::sensitive::SensitiveString; + +/// Iceberg-specific DataFusion options. +/// +/// It does deliberately not implement [`ExtensionOptions`](datafusion::config::ExtensionOptions) +/// and [`ConfigExtension`](datafusion::config::ConfigExtension) to avoid +/// plain-string handling of credential values and prevent SQL users from +/// setting unverified authentication properties such as: +/// +/// ```sql +/// SET iceberg.identity = 'alice'; +/// ``` +#[derive(Clone, Debug, Default)] +pub struct IcebergOptions { Review Comment: Ok this makes sense. As I looked into the distributed case it became apparent to me that we will need to differentiate between like a node-local credentials fetched from an auth API not transferred with the session, and something like a session_id, this points to having a dedicated struct seperate from the all encompassing `SessionContext`. I also understand the desire to not have Set/Debug auto show the raw string of the options. For this specific case - I don't think serialization is relevant anymore since the catalog call happens only in the coordinator. If/When we have different workers writing to iceberg then the node that starts the session then we do need to pass auth info over the wire. TLDR: A different options struct makes sense. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
