gaborkaszab commented on PR #17545: URL: https://github.com/apache/iceberg/pull/17545#issuecomment-5680550971
Thanks for taking a look, @RussellSpitzer ! This went through a number of iterations, and now that we moved the `decryptKeyMetadata()` method from the new, common interface to `EncryptionManager` and `EncryptionUtil`, not much is left there. Just took a quick look and I see it feasible to just simply get rid of the new interface and also remove usage of the existing `ManifestListFile` and pass the location and key ID wherever needed. cc @stevenzwu for your PR that builds on this. Let me give this a try and see where this break if it does. Will come back soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
