RussellSpitzer commented on code in PR #17545:
URL: https://github.com/apache/iceberg/pull/17545#discussion_r4049172702
##########
api/src/main/java/org/apache/iceberg/encryption/EncryptingFileIO.java:
##########
@@ -140,6 +145,16 @@ public InputFile newInputFile(ManifestListFile
manifestList) {
}
}
+ @Override
+ public InputFile newInputFile(String location, String keyId) {
+ if (keyId != null) {
Review Comment:
I'm not sure I follow. In this PR we now provide 2 APIs
new inputFile(String location)
and
new InputFile(String location, String keyID)
---
Usually I would expect the first to call the second. But here we have the
second call the first.
The question is what is the point of the first API if I have the second one
and can pass String keyID) as null. My assumption would be that if I pass
through a keyId I am attempting to have that used by the fileIO. If I have
passed through "null" I'm probably not doing something right because I should
have called "new inputFile(location)".
We also should consider the integration of this API with the "Length"
passthrough
Let me jump down to default definition to add some more comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
