RussellSpitzer commented on code in PR #17545:
URL: https://github.com/apache/iceberg/pull/17545#discussion_r4049185842
##########
api/src/main/java/org/apache/iceberg/io/FileIO.java:
##########
@@ -80,6 +85,13 @@ default InputFile newInputFile(ManifestListFile
manifestList) {
return newInputFile(manifestList.location());
}
+ default InputFile newInputFile(String location, String keyId) {
Review Comment:
While this made sense for "manifest List" i'm not sure it makes sense for a
generic path. The caller of this method has control over whether or not they
are passing through a String. If they choose to pass through a string shouldn't
we be using it?
Do we have other examples of API's where an argument can be ignored if it is
null and fall back to another polymorphism?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
