amogh-jahagirdar commented on code in PR #17984:
URL: https://github.com/apache/iceberg/pull/17984#discussion_r4027774585
##########
core/src/main/java/org/apache/iceberg/encryption/StandardEncryptionManager.java:
##########
@@ -212,6 +229,9 @@ private ByteBuffer newKey() {
return ByteBuffer.wrap(newKey);
}
+ /** Encrypted key metadata and its wrapping key. */
+ public record FileEncryptionKeys(EncryptedKey keyEncryptionKey, EncryptedKey
fileKey) {}
Review Comment:
Since it's public, @nastra @RussellSpitzer are we good with using record
types now? Don't remember where we landed on that in the code base. From a JDK
compatibility perspective it works, but are there other implications to this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
