smaheshwar-pltr commented on code in PR #17984:
URL: https://github.com/apache/iceberg/pull/17984#discussion_r3995581382
##########
core/src/main/java/org/apache/iceberg/ManifestListWriter.java:
##########
@@ -36,6 +37,9 @@ abstract class ManifestListWriter implements
FileAppender<ManifestFile> {
private final StandardEncryptionManager standardEncryptionManager;
private final NativeEncryptionKeyMetadata manifestListKeyMetadata;
private final OutputFile outputFile;
+ private boolean closed = false;
+ private ManifestListFile manifestListFile;
+ private ManifestListEncryptionResult encryptionResult;
Review Comment:
Yeah I felt like `ManifestListEncryptionKeys` is too confusingly named if it
contains both a MLK and a KEK (see @singhpk234's initial comments). I've now
gone with that though given I see your side too - but with a docstring to
clarify
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
