gaborkaszab commented on PR #17984: URL: https://github.com/apache/iceberg/pull/17984#issuecomment-5659982389
Hi @smaheshwar-pltr , thanks for the PR! In parallel I have [a PR](https://github.com/apache/iceberg/pull/17545) around the same area of the code that introduces a generic abstraction on top of/instead the manifest list specific classes and functions. I see that this PR introduces further manifest list specific stuff, and in case this is released we're going to immediately deprecate them to use the more generic approach. I'm wondering if it makes sense to merge the introduction of generic APIs first and build this one on top of that. I know the release now waits for the PR, however, I don't think we should introduce stuff now that we know we're going to replace and/or deprecate as a next step. WDYT @smaheshwar-pltr @RussellSpitzer @singhpk234 @stevenzwu ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
