rdblue commented on code in PR #18138:
URL: https://github.com/apache/iceberg/pull/18138#discussion_r4028136097
##########
core/src/main/java/org/apache/iceberg/ManifestInfoStruct.java:
##########
@@ -146,13 +142,8 @@ public long minSequenceNumber() {
}
@Override
- public ByteBuffer dv() {
- return dv != null ? ByteBuffer.wrap(dv) : null;
- }
-
- @Override
- public Long dvCardinality() {
- return dvCardinality;
+ public ManifestBitmap manifestDeletionVector() {
+ return dv != null ? MumblingBitmaps.read(ByteBuffer.wrap(dv)) : null;
Review Comment:
I think it's good that this is created lazily, but I'd like to reuse the
result rather than creating more than one because the implementation will
deserialize the offset and descriptor arrays.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
