rdblue commented on code in PR #18138:
URL: https://github.com/apache/iceberg/pull/18138#discussion_r4030203605
##########
core/src/main/java/org/apache/iceberg/ManifestInfoStruct.java:
##########
@@ -331,16 +322,9 @@ Builder minSequenceNumber(long sequenceNumber) {
return this;
}
- Builder dv(ByteBuffer buffer) {
- Preconditions.checkArgument(buffer != null, "Invalid DV: null");
- this.dv = ByteBuffers.toByteArray(buffer);
- return this;
- }
-
- Builder dvCardinality(long cardinality) {
- Preconditions.checkArgument(
- cardinality >= 0, "Invalid DV cardinality: %s (must be >= 0)",
cardinality);
- this.dvCardinality = cardinality;
+ Builder manifestDeletionVector(ManifestBitmap bitmap) {
Review Comment:
I'm not confident that `ManifestBitmap` is going to be used to set the DV.
I'd probably leave this unchanged for now, until we know more about how bitmaps
are passed after being constructed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
