amogh-jahagirdar commented on code in PR #18138:
URL: https://github.com/apache/iceberg/pull/18138#discussion_r4029509134
##########
core/src/main/java/org/apache/iceberg/ManifestInfo.java:
##########
@@ -56,12 +55,6 @@ interface ManifestInfo {
Types.NestedField DV =
Types.NestedField.optional(
522, "dv", Types.BinaryType.get(), "Deletion vector for manifest
entries");
- Types.NestedField DV_CARDINALITY =
Review Comment:
Is this something we want to drop, cc @rdblue ? One consequence of this
would be that we wouldn't be able to as easily tell just from manifest metadata
which leaf manifests should be compacted/rewritten (e.g.
dv_cardinality/number_entries gets you a ratio of how much has been deleted).
Considering we have to read the root and all the inline bitmaps in general,
maybe not a huge deal to always get it from the bitmap itself but we're
possibly missing a more selective projection to be able to determine if a leaf
should be rewritten.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
