rdblue commented on code in PR #18138:
URL: https://github.com/apache/iceberg/pull/18138#discussion_r4030224082
##########
core/src/test/java/org/apache/iceberg/TestManifestInfoStruct.java:
##########
@@ -31,7 +31,8 @@ class TestManifestInfoStruct {
@Test
void fieldAccess() {
ManifestInfoStruct info =
- new ManifestInfoStruct(10, 20, 3, 2, 1000L, 2000L, 300L, 200L, 5L, new
byte[] {0xF}, 1L);
+ new ManifestInfoStruct(
+ 10, 20, 3, 2, 1000L, 2000L, 300L, 200L, 5L,
MumblingBitmapTestUtil.emptyBitmapBytes());
Review Comment:
I think this test case is probably invalid. If a bitmap's cardinality is 0,
we should always write `null` instead of writing a bitmap. For tests like this,
we should use valid values.
This is a good case to note for the write wrapper.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
