rdblue commented on code in PR #18138:
URL: https://github.com/apache/iceberg/pull/18138#discussion_r4030228967
##########
core/src/test/java/org/apache/iceberg/TestManifestInfoStruct.java:
##########
@@ -42,8 +43,20 @@ void fieldAccess() {
assertThat(info.deletedRowsCount()).isEqualTo(300L);
assertThat(info.replacedRowsCount()).isEqualTo(200L);
assertThat(info.minSequenceNumber()).isEqualTo(5L);
- assertThat(info.dv()).isNotNull();
- assertThat(info.dvCardinality()).isEqualTo(1L);
+ assertThat(info.manifestDeletionVector().buffer())
+ .isEqualTo(MumblingBitmapTestUtil.emptyBitmap().buffer());
+ assertThat(info.manifestDeletionVector().cardinality()).isEqualTo(0);
+ }
+
+ @Test
+ void manifestDeletionVectorIsReused() {
Review Comment:
What is the value of testing this? Is this a contract that `ManifestInfo`
*must* follow? If not, then I think it's just extra code to review and maintain
that could break.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
