pvary commented on code in PR #18027:
URL: https://github.com/apache/iceberg/pull/18027#discussion_r4036767455
##########
core/src/main/java/org/apache/iceberg/deletes/EmptyPositionDeleteIndex.java:
##########
@@ -48,6 +51,15 @@ public boolean isEmpty() {
return true;
}
+ @Override
+ public void forEachInRange(long posStart, long posEnd, LongConsumer
consumer) {
+ Preconditions.checkArgument(
Review Comment:
I requested that we should have the same behaviour between the
implementations. That is why the check.
I'm not sure that throwing an UOE is a good idea. `BaseDeleteLoader` uses
`PositionDeleteIndex.empty()` for data files where no position is deleted. We
might throw if we start using `forEachInRange` there, even if the correct
response is not to call the consumer at all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
