JeonDaehong commented on code in PR #18027:
URL: https://github.com/apache/iceberg/pull/18027#discussion_r4037314062
##########
core/src/main/java/org/apache/iceberg/deletes/EmptyPositionDeleteIndex.java:
##########
@@ -48,6 +51,15 @@ public boolean isEmpty() {
return true;
}
+ @Override
+ public void forEachInRange(long posStart, long posEnd, LongConsumer
consumer) {
+ Preconditions.checkArgument(
Review Comment:
Agreed
Thanks for the `BaseDeleteLoader` pointer, that is the case I had in mind
too. Keeping it as is: the override also avoids the default implementation
walking the whole range calling `isDeleted`, which is always false here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
