pvary commented on code in PR #18238:
URL: https://github.com/apache/iceberg/pull/18238#discussion_r4091864597
##########
parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java:
##########
@@ -1509,6 +1514,15 @@ public ReadBuilder withAADPrefix(ByteBuffer aadPrefix) {
return this;
}
+ public ReadBuilder withMaxAllocationInBytes(int
newMaxAllocationSizeInBytes) {
+ return set(ALLOCATION_SIZE_PROPERTY,
String.valueOf(newMaxAllocationSizeInBytes));
+ }
+
+ public ReadBuilder useHadoopVectoredIo(boolean newUseHadoopVectoredIo) {
+ return set(
+ ParquetInputFormat.HADOOP_VECTORED_IO_ENABLED,
String.valueOf(newUseHadoopVectoredIo));
+ }
Review Comment:
Don't change the API.
Why not just use the values in the config when initializing the builder?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
