pvary commented on code in PR #18238:
URL: https://github.com/apache/iceberg/pull/18238#discussion_r4103060341
##########
parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java:
##########
@@ -1535,9 +1535,13 @@ public <D> CloseableIterable<D> build() {
for (String property : READ_PROPERTIES_TO_REMOVE) {
conf.unset(property);
}
+ // populate before constructing the builder:
HadoopReadOptions.Builder parses several
+ // fields (e.g. allocation size, vectored IO) from the Configuration
once, at
+ // construction time, not from later set(key, value) calls.
+ properties.forEach(conf::set);
Review Comment:
Should we remove `READ_PROPERTIES_TO_REMOVE` from these as well? Maybe just
switch the order?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
