peterphitran commented on code in PR #18238:
URL: https://github.com/apache/iceberg/pull/18238#discussion_r4109198535
##########
parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java:
##########
@@ -1552,7 +1556,6 @@ public <D> CloseableIterable<D> build() {
optionsBuilder.withDecryption(fileDecryptionProperties);
}
- optionsBuilder.withUseHadoopVectoredIo(true);
Review Comment:
Did some digging the line was written when Iceberg was on the old Parquet
1.15 where default was false and it [became
true](https://github.com/apache/parquet-java/pull/3128/changes) on 1.16, so
this is fixing the issue for >=1.16. But this also impacts older versions so
instead put in a fix setting the default to true only when it isn't already
set, so vectored IO stays enabled regardless of the parquet-java version, while
an explicit false from set() or the Hadoop configuration is still respected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
