rdblue commented on code in PR #18248:
URL: https://github.com/apache/iceberg/pull/18248#discussion_r4097608005
##########
core/src/test/java/org/apache/iceberg/V4TestComparators.java:
##########
@@ -94,9 +94,7 @@ private static <T extends Comparable<T>> Comparator<T>
natural() {
.thenComparing(Tracking::dvSnapshotId, natural())
.thenComparing(Tracking::firstRowId, natural())
.thenComparing(Tracking::deletedPositions, BYTES)
- .thenComparing(Tracking::replacedPositions, BYTES)
- .thenComparing(Tracking::manifestLocation, natural())
- .thenComparingLong(Tracking::manifestPos));
+ .thenComparing(Tracking::replacedPositions, BYTES));
Review Comment:
This was needed because the inheritance tests don't need to validate the
_file or _pos fields, and the inheritance test for _file and _pos just verifies
the metadata columns and doesn't use this comparator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
