rdblue commented on code in PR #18248:
URL: https://github.com/apache/iceberg/pull/18248#discussion_r4097617106


##########
core/src/test/java/org/apache/iceberg/TestV4ManifestReader.java:
##########
@@ -117,6 +118,8 @@ class TestV4ManifestReader {
       V4TestComparators.trackedFileStatusOnly(ID_PARTITIONED_TYPE);
   private static final Comparator<TrackedFile> UNPARTITIONED_FILE_COMPARATOR =
       V4TestComparators.trackedFileStatusOnly(UNPARTITIONED_TYPE);
+  private static final Comparator<TrackedFile> FILE_AND_TRACKING_COMPARATOR =
+      V4TestComparators.trackedFile(UNPARTITIONED_TYPE);

Review Comment:
   The majority of the changes to this file update inheritance and first row ID 
assignment tests to validate the entire `Tracking` struct, like these tests do 
for `TrackedFile` using the `FILE_COMPARATOR`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to