moggaa commented on code in PR #17653:
URL: https://github.com/apache/iceberg/pull/17653#discussion_r4122006225
##########
kafka-connect/kafka-connect/src/test/java/org/apache/iceberg/connect/data/TestSinkWriter.java:
##########
@@ -155,6 +159,51 @@ public void testDynamicRoute() {
assertThat(writerResult.tableReference().identifier()).isEqualTo(TABLE_IDENTIFIER);
}
+ @ParameterizedTest
+ @ValueSource(booleans = {true, false})
+ public void testDynamicRouteReplaceNullWithDefault(boolean
replaceNullWithDefault) {
Review Comment:
Added `testStaticRouteReplaceNullWithDefault` in 3f9aec76b, mirroring the
dynamic-route test: with the option on, the schema default routes the record;
with it off, the explicitly-null route field is skipped.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
