moggaa commented on code in PR #17653: URL: https://github.com/apache/iceberg/pull/17653#discussion_r4122001722
########## docs/docs/kafka-connect.md: ########## @@ -94,6 +95,11 @@ If `iceberg.tables.dynamic-enabled` is `false` (the default) then you must speci `iceberg.tables.dynamic-enabled` is `true` then you must specify `iceberg.tables.route-field` which will contain the name of the table. +When `iceberg.tables.replace-null-with-default` is set to `false`, a record whose route field is Review Comment: Restructured in d585a0d49 — the paragraph now leads with the option's semantics, then the routing caveat, then the JSON converter note. One correction on the version: the converter's `replace.null.with.default` landed in Kafka 3.5.0, not 3.6 — [KAFKA-8713](https://issues.apache.org/jira/browse/KAFKA-8713) is marked fixed in 3.5.0, and [the 3.5.0 tag](https://github.com/apache/kafka/blob/3.5.0/connect/json/src/main/java/org/apache/kafka/connect/json/JsonConverterConfig.java#L49-L51) already applies the config in both the serialization and deserialization paths — so the docs say 3.5.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
